-
Notifications
You must be signed in to change notification settings - Fork 8
Vehicle assignments #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Working off of @skyqrose 's outline of vehicle_assignments.txt, cal-itp#28 (comment). Attempted alignment with GTFS-Vehicles proposal.
for more information, see https://pre-commit.ci
Based on this #28 (comment) - what @skyqrose outlined in August Notes:
|
Some internal discussion at Optibus: |
These are vehicle properties that Optibus currently exports in a non TODS format. Which properties should be included in TODS? Vehicle properties example.xlsx
|
From the fields mentioned above, I would remove at least To me, those look too undefined, covered by other attributes like I'm also very unsure about |
fixes cal-itp#85 (comment) responds to cal-itp#85 (comment)
…tional-data-standard into vehicle_assignments
@skyqrose @safrazier17 Can you help guide process here? Since I worked off the #81 branch, this has the rosters and employee assignments spec draft. Should I remove those changes? Will we vote on the two PRs separately or together? Merge separately? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left lots of line-by-line comments.
As for the process, I think this is completely independent from #81. We could split them into two separate PRs/votes.
crew/rostering is in cal-itp#81 cal-itp#85 (review)
We've been discussing this internally at Optibus, including with some CAD/AVL partners. For the upcoming version, we propose a "least viable" approach:
This removes speculative vehicle attributes. The CAD/AVL should be able to look up vehicle attributes stored in that system. Thoughts/reactions? |
That does remove the ability to assign a type of vehicle without assigning a specific vehicle, but that's probably fine if we're aiming for a least viable approach. |
@skyqrose If we pass a version of this without vehicle types, I think the discussion was still useful, so thanks for the review and great comments. And if we do add in more vehicle attributes besides the ID and license plate, then bringing back in vehicle type seems useful. |
Minimum viable vehicle assignments proposal. see cal-itp#85 (comment)
https: //github.com/cal-itp/pull/85#discussion_r1890259183 Co-Authored-By: Jeff Kessler <[email protected]>
Pre-vote checklist (@antrim)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking much better now
e.g. bus number. thanks @skyqrose Co-authored-by: Sky Rose <[email protected]>
-trip (remove outdated reference) Co-authored-by: Sky Rose <[email protected]>
VOTING PERIOD OPENVoting is open on this PR through 11:59:59 UTC on WHO IS ELIGIBLE TO VOTEAny individual may vote as an ODS Contributor; in voting, Contributors are acknowledging and agreeing to the ODS Contributor Agreement and ODS Code of Conduct. Issue Working Group members @BTollison, @jeffkessler-keolis, @skyqrose, @jfabi, @safrazier17, @antrim, @hodb are not eligible to vote on this proposal. HOW TO VOTE
OUTCOMES
|
+1 [Optibus] |
[Sarah from Swiftly] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caltrans would like to have some more information on this specification modification proposal before voting. We conceptually like the idea of noting vehicle assignments. However, we echo @sbindman's inquiry and concerns into how this could be used in practice. Vehicle assignments can vary widely from day-to-day or even on an intra-day basis.
It would be great if some clarity could be introduced up-front into the use cases that these vehicle assignments are likely to help resolve and to suggest other methods for delivering vehicle assignments when the use cases demand finer-grained detail or more realtime delivery of vehicle assignments.
To guess on how this might be helpful, this seems mainly useful for fleet planning and optimization use cases, but in a realtime sense it may not be useful and could be too rigid to support intra-day or even intra-week vehicle assignment variability. And then from a historical perspective (perhaps even realtime??), it seems like the TIDES Trips Performed could be more appropriate for noting the exact operational vehicle assignments that ended up occurring.
Also, a minor formatting request is to note these new files at the list of files towards the beginning of the document.
@sbindman Our intended use case is transmitting the vehicle assignments for the immediate next days (typically the next @evansiroky We did not consider historical data, for that it indeed will be better to use TIDES Trips Performed. It's about the assignments for the next few days only. Apart from the use case of getting existing vehicle assignments into a CAD/AVL system, transmitting the assignments for the next day can also be used for charge management systems (battery-electric buses). That system needs to know which vehicles will enter/leave a depot in the next day so that they can plan the charging in the best possible way. As with the rest of TODS, we did not have real-time use cases in mind here. |
@timon-k thanks for the clarifications that TODS is intended as a "planned" dataset. I will go ahead and vote a cautious +1 on behalf of Caltrans as I think the concept makes sense, but still wonder about how applicable this is in the field. I think it would be great to clarify the timing and use cases. The GTFS specification notes that:
This is somewhat in conflict with what you've mentioned as the |
I am neutral on PRs 85 and 87. In my eyes, vehicle and driver assignments are a different interface and data is updated on a different schedule, but I see that it can be useful. |
+1 [San Francisco Bay Ferry] |
Looks like trying this from my work computer yesterday didn't go through unfortunately, but +1 [CTA] |
VOTING PERIOD CLOSEDThe voting period for this proposal closed yesterday, April 15 at 11:59:59 UTC. The proposal received the following votes: Support (3): @timon-k (Optibus), @evansiroky (Cal-ITP), @arthi-weta (WETA) The proposal has met the threshold of support needed and passes. |
for more information, see https://pre-commit.ci
fixed: missing end CSV code/data block
Update order of file descriptions
restore the employee_run_dates.txt field table, which was accidentally removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@safrazier17 I believe this is ready to be merged
docs/spec/index.md
Outdated
@@ -155,11 +157,36 @@ This file should represent the schedule after holidays, vacations, and other sch | |||
|
|||
Each run and date combination may appear 0 times in this file (if there's no assigned employee), 1 time, or multiple times (if multiple employees are assigned to the same run on the same date). | |||
|
|||
Primary Key: `*` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this deletion intended to be here? It may have snuck in during a merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. That is a mistake! Will resolve, thank you
restore note for employee_run_dates.txt Primary Key: `*`
Proposed spec in response to issue #28 "Allocating drivers and vehicles in ODS".
What it does: Assign individual vehicles to blocks.
What it does NOT do:
Changes included:
vehicles.txt
: ID, text label, license plate. Only a few attribute fields are defined for a minimum viable proposal. TODS consumers may be able to look up additional attributes by vehicle_id. More attributes can be defined in future TODS versions.vehicle_assignments.txt
: Assignments by service date,block_id
,service_id